Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional"No Upcoming Events" text #265

Open
arjunkalburgi opened this issue Jul 21, 2017 · 2 comments
Open

Optional"No Upcoming Events" text #265

arjunkalburgi opened this issue Jul 21, 2017 · 2 comments

Comments

@arjunkalburgi
Copy link

arjunkalburgi commented Jul 21, 2017

Hello,

I was wondering if it's possible to get a toggle for the text to appear when there is an empty_event_list.

There are different ways to implement it ofc, but I think it would be pretty minor.

Looks like after adding the toggle cell, R.string.no_upcoming_events can be set to empty and then everything in the EventAppWidgetProvider would work normally as it does:

        @IdRes int emptyViewId = R.id.empty_event_list;

        rv.setEmptyView(R.id.event_list, emptyViewId);

        rv.setTextViewText(emptyViewId, settings.getContext().getText(

                permissionsGranted ? R.string.no_upcoming_events : R.string.grant_permissions_verbose

        ));

Thanks!

@yvolk
Copy link
Collaborator

yvolk commented Oct 13, 2019

So we have these options now, as I understand:

  1. Display "No upcoming events" / "No events to show" as this is now (since v.3)
  2. Display nothing as I understood @arjunkalburgi Correct?
  3. Display current day header (even if day headers are turned off), ass suggested in Display current date if there are no events #282

@yvolk
Copy link
Collaborator

yvolk commented Oct 14, 2019

@arjunkalburgi Or I misunderstood what you mean by "toggle for the text"
Since v.3 the Widget layout doesn't have a separate view to show, when there are no events: I simply add a list item that tells this. See screenshots here: #282 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants