You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Scipy is recommending migration to the new sparse array format, see note here. PorePy will gradually migrate to the new style, but to make that possible, the Ad parsing machinery must be updated. This can be implemented in the following steps:
In all special methods that define mathematical operations (__add__ etc.) in the AdArray class, cases that currently allow for sps.spmatrix should also allow for sps.sparray.
In test_forward_mode, some tests should be modified to cover sparse arrays instead of, or in addition to, sparse matrices. What to replace and what to duplicate must be decided.
In test_operators, the test test_arithmetic_operations_on_ad_objects must be expanded to cover sparse arrays in addition to matrices. In this case, both scipy sparse formats must be kept, since we will need to support both options for the foreseeable future. Note however that we can use exactly the same setup for the two formats, the point is simply to ensure the Ad evaluation framework can deal with both cases.
The text was updated successfully, but these errors were encountered:
As a general comment yes. Not sure how relevant it is for this issue, which mainly considers changes to be made deep inside functions, but that is a different question.
Scipy is recommending migration to the new sparse array format, see note here. PorePy will gradually migrate to the new style, but to make that possible, the Ad parsing machinery must be updated. This can be implemented in the following steps:
__add__
etc.) in theAdArray
class, cases that currently allow forsps.spmatrix
should also allow forsps.sparray
.test_forward_mode
, some tests should be modified to cover sparse arrays instead of, or in addition to, sparse matrices. What to replace and what to duplicate must be decided.test_operators
, the testtest_arithmetic_operations_on_ad_objects
must be expanded to cover sparse arrays in addition to matrices. In this case, both scipy sparse formats must be kept, since we will need to support both options for the foreseeable future. Note however that we can use exactly the same setup for the two formats, the point is simply to ensure the Ad evaluation framework can deal with both cases.The text was updated successfully, but these errors were encountered: