From 42355702511f3ce9df1c18c3cf2724608f9e546c Mon Sep 17 00:00:00 2001 From: Lewis Cowper <593574+lewiscowper@users.noreply.github.com> Date: Mon, 3 Jan 2022 17:39:59 +0100 Subject: [PATCH 1/3] Add image pull secrets for private image registries --- charts/metabase/templates/deployment.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/charts/metabase/templates/deployment.yaml b/charts/metabase/templates/deployment.yaml index b73d4f0..6d54e8e 100644 --- a/charts/metabase/templates/deployment.yaml +++ b/charts/metabase/templates/deployment.yaml @@ -31,6 +31,12 @@ spec: initContainers: {{ toYaml .Values.extraInitContainers | nindent 8 }} {{- end }} + {{- if len .Values.image.pullSecrets > 0 }} + imagePullSecrets: + {{- range .Values.image.pullSecrets }} + - name: {{ . | quote }} + {{- end }} + {{- end }} containers: - name: {{ .Chart.Name }} image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" From d8e81e8dc0b2b0d82fe394b0a6aec5c9449cea95 Mon Sep 17 00:00:00 2001 From: Lewis Cowper <593574+lewiscowper@users.noreply.github.com> Date: Mon, 3 Jan 2022 17:41:23 +0100 Subject: [PATCH 2/3] Update deployment.yaml --- charts/metabase/templates/deployment.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/metabase/templates/deployment.yaml b/charts/metabase/templates/deployment.yaml index 6d54e8e..1ebbcb5 100644 --- a/charts/metabase/templates/deployment.yaml +++ b/charts/metabase/templates/deployment.yaml @@ -31,7 +31,7 @@ spec: initContainers: {{ toYaml .Values.extraInitContainers | nindent 8 }} {{- end }} - {{- if len .Values.image.pullSecrets > 0 }} + {{- if gt (len .Values.image.pullSecrets) 0 }} imagePullSecrets: {{- range .Values.image.pullSecrets }} - name: {{ . | quote }} From 7d08627747bd105f253a383931aa0a9a57eae8ad Mon Sep 17 00:00:00 2001 From: Lewis Cowper <593574+lewiscowper@users.noreply.github.com> Date: Wed, 5 Jan 2022 11:18:09 +0100 Subject: [PATCH 3/3] update chart version, add default value and documentation --- charts/metabase/Chart.yaml | 2 +- charts/metabase/README.md | 1 + charts/metabase/values.yaml | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/charts/metabase/Chart.yaml b/charts/metabase/Chart.yaml index 6a5593c..646f22e 100644 --- a/charts/metabase/Chart.yaml +++ b/charts/metabase/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v1 description: The easy, open source way for everyone in your company to ask questions and learn from data. name: metabase -version: 1.3.2 +version: 1.3.3 appVersion: v0.41.5 maintainers: - name: pmint93 diff --git a/charts/metabase/README.md b/charts/metabase/README.md index ae032bf..281f7c1 100644 --- a/charts/metabase/README.md +++ b/charts/metabase/README.md @@ -58,6 +58,7 @@ The following table lists the configurable parameters of the Metabase chart and | image.tag | controller container image tag | v0.41.5 | | image.command | controller container image command | [] | | image.pullPolicy | controller container image pull policy | IfNotPresent | +| image.pullSecrets | controller container image pull secrets | [] | | fullnameOverride | String to fully override metabase.fullname template | null | | listen.host | Listening on a specific network host | 0.0.0.0 | | listen.port | Listening on a specific network port | 3000 | diff --git a/charts/metabase/values.yaml b/charts/metabase/values.yaml index 47cd993..0ad8dcb 100644 --- a/charts/metabase/values.yaml +++ b/charts/metabase/values.yaml @@ -10,6 +10,7 @@ image: tag: v0.41.5 command: [] pullPolicy: IfNotPresent + pullSecrets: [] ## String to fully override metabase.fullname template ##