From 73def0f49796161ea07d89faae544157c758fd64 Mon Sep 17 00:00:00 2001
From: Maxime L <98211455+kaxyum@users.noreply.github.com>
Date: Thu, 15 Aug 2024 23:54:58 +0200
Subject: [PATCH] Add missing field `ViewOffset` to CameraSetInstruction (#264)

---
 src/types/camera/CameraSetInstruction.php | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/types/camera/CameraSetInstruction.php b/src/types/camera/CameraSetInstruction.php
index ba701177..b8512d10 100644
--- a/src/types/camera/CameraSetInstruction.php
+++ b/src/types/camera/CameraSetInstruction.php
@@ -14,6 +14,7 @@
 
 namespace pocketmine\network\mcpe\protocol\types\camera;
 
+use pocketmine\math\Vector2;
 use pocketmine\math\Vector3;
 use pocketmine\network\mcpe\protocol\serializer\PacketSerializer;
 
@@ -25,6 +26,7 @@ public function __construct(
 		private ?Vector3 $cameraPosition,
 		private ?CameraSetInstructionRotation $rotation,
 		private ?Vector3 $facingPosition,
+		private ?Vector2 $viewOffset,
 		private ?bool $default
 	){}
 
@@ -38,6 +40,8 @@ public function getRotation() : ?CameraSetInstructionRotation{ return $this->rot
 
 	public function getFacingPosition() : ?Vector3{ return $this->facingPosition; }
 
+	public function getViewOffset() : ?Vector2{ return $this->viewOffset; }
+
 	public function getDefault() : ?bool{ return $this->default; }
 
 	public static function read(PacketSerializer $in) : self{
@@ -46,6 +50,7 @@ public static function read(PacketSerializer $in) : self{
 		$cameraPosition = $in->readOptional($in->getVector3(...));
 		$rotation = $in->readOptional(fn() => CameraSetInstructionRotation::read($in));
 		$facingPosition = $in->readOptional($in->getVector3(...));
+		$viewOffset = $in->readOptional($in->getVector2(...));
 		$default = $in->readOptional($in->getBool(...));
 
 		return new self(
@@ -54,6 +59,7 @@ public static function read(PacketSerializer $in) : self{
 			$cameraPosition,
 			$rotation,
 			$facingPosition,
+			$viewOffset,
 			$default
 		);
 	}
@@ -64,6 +70,7 @@ public function write(PacketSerializer $out) : void{
 		$out->writeOptional($this->cameraPosition, $out->putVector3(...));
 		$out->writeOptional($this->rotation, fn(CameraSetInstructionRotation $v) => $v->write($out));
 		$out->writeOptional($this->facingPosition, $out->putVector3(...));
+		$out->writeOptional($this->viewOffset, $out->putVector2(...));
 		$out->writeOptional($this->default, $out->putBool(...));
 	}
 }