From 13cb51b95714fc4dbb2f34a26f536aa810325855 Mon Sep 17 00:00:00 2001 From: "Dylan K. Taylor" Date: Sat, 4 Dec 2021 20:52:18 +0000 Subject: [PATCH] Don't carelessly expose internal-use constant to the API if we want to actually expose these, we should probably consider putting them in a separate class. --- src/Binary.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Binary.php b/src/Binary.php index 604f51c..ff27d62 100644 --- a/src/Binary.php +++ b/src/Binary.php @@ -39,13 +39,13 @@ use const PHP_INT_MAX; class Binary{ - public const SIZEOF_BYTE = 1; - public const SIZEOF_SHORT = 2; - public const SIZEOF_INT = 4; - public const SIZEOF_LONG = 8; + private const SIZEOF_BYTE = 1; + private const SIZEOF_SHORT = 2; + private const SIZEOF_INT = 4; + private const SIZEOF_LONG = 8; - public const SIZEOF_FLOAT = 4; - public const SIZEOF_DOUBLE = 8; + private const SIZEOF_FLOAT = 4; + private const SIZEOF_DOUBLE = 8; public static function signByte(int $value) : int{ return $value << 56 >> 56;