Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add events for server startup completed #6496

Open
dktapps opened this issue Nov 12, 2024 · 1 comment
Open

Add events for server startup completed #6496

dktapps opened this issue Nov 12, 2024 · 1 comment
Labels
Category: API Related to the plugin API Easy task Probably really easy to do, good task for first-time contributors Opinions Wanted Request for comments & opinions from the community Type: Enhancement Contributes features or other improvements to PocketMine-MP

Comments

@dktapps
Copy link
Member

dktapps commented Nov 12, 2024

Description

This was suggested years ago as part of a much larger proposal (#2828), which has since been rejected and broken down.

This would run at the end of server startup as seen in 38ce83d.

Justification

Honestly not too sure.

Alternative methods

This is already achievable by scheduling a delayed task with a delay of 0 during startup.
However, if there's a significant demand for it, an event might be a nicer way of doing this.
@dktapps dktapps added Category: API Related to the plugin API Type: Enhancement Contributes features or other improvements to PocketMine-MP Opinions Wanted Request for comments & opinions from the community labels Nov 12, 2024
@dktapps
Copy link
Member Author

dktapps commented Nov 12, 2024

Similar idea as StartupPostWorldsLoadedEvent as proposed in #6330, but in a way smaller proposal.

@dktapps dktapps added the Easy task Probably really easy to do, good task for first-time contributors label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: API Related to the plugin API Easy task Probably really easy to do, good task for first-time contributors Opinions Wanted Request for comments & opinions from the community Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dktapps