Ability to give plugin.yml permissions to console only

[Gaprix]

Description

Now if you specify the permission, marked as "default: false", the console won't be able to run the command

permissions:
  myplugin.command.test:
    default: false

I suggest allowing the ConsoleCommandSender to execute such commands

Justification

It is often necessary to restrict a dangerous (or unwanted) command even to server operators. In this case, access to this command can be given manually to players through the permission manager. But in that case, the ConsoleCommandSender will lose the access to it, which is confusing

Alternative methods

Code like this may be used to force-grant the permission

$server = Server::getInstance();
$refObj = new \ReflectionObject($server);
$field = $refObj->getProperty("consoleSender");
$field->setAccessible(true);

$permission = PermissionManager::getInstance()->getPermission("myplugin.command.test");

$consoleSender = new ConsoleCommandSender($server, $server->getLanguage());
$consoleSender->addAttachment($this)->setPermission($permission, true);

$field->setValue($server, $consoleSender);

[dktapps]

This works as intended. Changing it the way you want would be misleading.

What we really need is a way to specify pocketmine.group.console in plugin.yml. Currently it's not possible to say default: console or similar.

[dktapps]

If anyone wants to take a shot at this:

https://github.com/pmmp/PocketMine-MP/blob/stable/src/permission/PermissionParser.php
https://github.com/pmmp/PocketMine-MP/blob/stable/src/plugin/PluginManager.php#L189