Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust rule for Valtio v2 #47

Closed
dai-shi opened this issue Apr 11, 2024 · 4 comments · Fixed by #48
Closed

Adjust rule for Valtio v2 #47

dai-shi opened this issue Apr 11, 2024 · 4 comments · Fixed by #48

Comments

@dai-shi
Copy link
Member

dai-shi commented Apr 11, 2024

In v2, the incompatibility with useMemo and so on will be resolved, pmndrs/valtio#866
so, this plugin should avoid warning such usages with v2.

I wonder if there's a way in eslint to change the behavior based on Valtio versions. Otherwise, we can simply upgrade, which is reasonable for simplicity too.

@barelyhuman Can you work on it? It's not in a hurry.

@barelyhuman
Copy link
Collaborator

I'll check both options this weekend and implement accordingly

@barelyhuman
Copy link
Collaborator

Since the sandbox isn't working, any chance you can validate #48 locally?
Will merge post that

@dai-shi
Copy link
Member Author

dai-shi commented May 28, 2024

I don't think it's easy even with csb build. Let me review tests.

@barelyhuman
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants