Shallow import issue on React Native

[glitch-txs]

Summary

Hi, while installing zustand in a React Native app and calling shallow it will throw a warn even when it's NOT imported as default.

import { shallow } from 'zustand/shallow'

shallow()

WARN  [DEPRECATED] Default export is deprecated. Instead use `import { shallow } from 'zustand/shallow'`.

This doesn't happen in zustand 4.3.1

the issue seems to be in the way the code was compiled.

Check on npm the last lines in shallow.js

exports.default = shallow;
exports.shallow = shallow$1;

module.exports = shallow$1;
module.exports.shallow = shallow;
exports.default = module.exports;

by changing it for this it works well

exports.default = shallow;
exports.shallow = shallow$1;

module.exports = shallow$1;
module.exports.shallow = shallow$1; // <-- change here
exports.default = module.exports;

Link to reproduction

https://github.com/glitch-txs/zustand-rn-warn/blob/main/App.tsx

[dbritto-dev]

@glitch-txs weird, there's no warnings -> https://codesandbox.io/p/sandbox/magical-star-f7r88x?file=%2Fsrc%2FApp.tsx%3A7%2C1

[glitch-txs]

Hi, somehow this only happens in React Native but it works well in React + Vite. I tested both

[dbritto-dev]

Maybe something related to Metro bundler I guess

[dai-shi]

Oops, look like some recent change broke our manual patching...

[dai-shi]

#2128 should fix it.

https://ci.codesandbox.io/status/pmndrs/zustand/pr/2128
Please try "Local Install Instructions" ☝️

[glitch-txs]

Thanks! This works great! 🤝