Syntax Errors in pngstruct.h (Build failure)

[Dutchman101]

Compiler: Build Tools 2022: 17.13.35825.156 (Visual Studio 2022, 17.13.2)

Fails to build libpng as-is.

Severity Code Description File Line

Error C2146 syntax error: missing '}' before identifier 'PNG_INDEX_unknown' in file: libpng > pngstruct.h @ Line 101
Error C2143 syntax error: missing ';' before '}' in file: libpng > pngstruct.h @ Line 102
Error C2059 syntax error: '}' in file: libpng > pngstruct.h @ Line 102

@jbowler
@ctruta

[jbowler]

You need to give a full repro, step-by-step. E.g. https://github.com/OpenSC/OpenSC/wiki/How-to-write-a-good-bug-report (though that is written for UI bugs).

In this case you need to be clear which Visual Studio project file you used and you need to have done a "clean" build. You also need to include the complete console output from VS; not just the last error, the whole thing (attach it to the bug as a .txt file.)

[Dutchman101]

You need to give a full repro, step-by-step. E.g. https://github.com/OpenSC/OpenSC/wiki/How-to-write-a-good-bug-report (though that is written for UI bugs).

In this case you need to be clear which Visual Studio project file you used and you need to have done a "clean" build. You also need to include the complete console output from VS; not just the last error, the whole thing (attach it to the bug as a .txt file.)

@jbowler

You can reproduce it from within our project, which attempted the upgrade to libpng 1.6.47 (coming from 1.6.43). More easily, you can review the Actions Build failure when building from the upgrade commit: https://github.com/multitheftauto/mtasa-blue/actions/runs/13622834797/job/38075112924 and it also lists the Syntax Error output of the job, as much as it does locally in Visual Studio.

Reproduction:

1. Locally clone the mtasa-blue repo. Check out commit dee4636b2a59080c142b72692d4faf05d6686120
2. Merge the "Upgrade to libpng 1.6.47" commit again: multitheftauto/mtasa-blue@bab9c3c into base
3. Build and observe failure with the given syntax build errors

The platform is Windows 11 24H2 (x64 OS, x86 project)

I will gather the full build log and try to assemble a minimal repro project soon