Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds option to pull arm64/amd64 examples #1196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Adds option to pull arm64/amd64 examples #1196

wants to merge 1 commit into from

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Jan 16, 2025 •
edited
Loading

feat: Adds option to pull arm64/amd64 examples

What does this PR do?

  • Adds the ability to choose what initial arm64 or amd64 image example
    you want
  • Defaults to native architecture when initially loading
  • Pulls the architecture correctly

Screenshot / video of UI

Screen.Recording.2025-01-16.at.2.14.53.PM.mov

What issues does this PR fix or reference?

Closes #1154

How to test this PR?

  1. Go to examples page
  2. Select from the drop down the arch you want
  3. Pull the image & build

@cdrage cdrage requested a review from a team as a code owner January 16, 2025 20:20
@cdrage cdrage requested review from benoitf, dgolovin and axel7083 and removed request for a team January 16, 2025 20:20
@cdrage cdrage force-pushed the pull-different-archs branch from 442c1bc to 7869519 Compare January 16, 2025 20:33
@cdrage
feat: Adds option to pull arm64/amd64 examples
5c9bb3f 
### What does this PR do?

* Adds the ability to choose what initial arm64 or amd64 image example
  you want
* Defaults to native architecture when initially loading
* Pulls the architecture correctly

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#1154

### How to test this PR?

<!-- Please explain steps to reproduce -->

1. Go to examples page
2. Select from the drop down the arch you want
3. Pull the image & build

Signed-off-by: Charlie Drage <[email protected]>
@cdrage cdrage force-pushed the pull-different-archs branch from 7869519 to 5c9bb3f Compare January 16, 2025 20:39
deboer-tim
deboer-tim requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the copyright in the .ts files (2024-2025).

Instead of adding isArm() to the API, could we do getArch()? Seems a bit cleaner for future use. (or we could use os.arch() in the frontend?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deboer-tim deboer-tim deboer-tim requested changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner automatically assigned from podman-desktop/reviewers

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from podman-desktop/reviewers

@axel7083 axel7083 Awaiting requested review from axel7083 axel7083 is a code owner automatically assigned from podman-desktop/reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples should have an option to pull AMD64 or ARM64 / default to host
2 participants
@cdrage @deboer-tim