Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Olshansk debugging round2 #10

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Olshansk debugging round2 #10

merged 6 commits into from
Jul 30, 2024

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Jul 28, 2024 •
edited
Loading

Two key changes:

  1. Update to the dev container to enable building on an M1 MacBook
  2. Instructions on how to connect and read from postgres directly

@Olshansk Olshansk mentioned this pull request Jul 28, 2024
Closed
14 tasks
@Olshansk Olshansk marked this pull request as ready for review July 28, 2024 21:43
@Olshansk Olshansk self-assigned this Jul 28, 2024
@Olshansk Olshansk added the bug Something isn't working label Jul 28, 2024
@Olshansk
Copy link
Member Author

@orgecuesta Please test & review on your machine!

@jorgecuesta
Copy link
Collaborator

will do on Monday @Olshansk

@jorgecuesta
Add amd64 and arm64 to build targets on CI to ensure both are properl…
5f759fc 
…y working. Also added @Olshansk change on dev-node.dockerfile (dev & test) to node.dockerfile (production)
@jorgecuesta
Copy link
Collaborator

@Olshansk I replicated your changes to the production image and added platform targets to CI to check if this happens again.

@Olshansk
Copy link
Member Author

Thanks @jorgecuesta! Going to ship it.

@Olshansk Olshansk merged commit 932f2b2 into main Jul 30, 2024
4 checks passed
@Olshansk Olshansk deleted the olshansk_debugging_round2 branch July 30, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanchriswhite bryanchriswhite Awaiting requested review from bryanchriswhite

Assignees

@Olshansk Olshansk

Labels
bug Something isn't working
Projects
Shannon
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Olshansk @jorgecuesta