Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Integrate Tilt development environment #23

Merged
merged 23 commits into from
Oct 23, 2024
Merged

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Oct 14, 2024

Summary

Integrate Tilt (and k8s/helm) development environment.

Run:

tilt up

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

Documentation changes (only if making doc changes)

  • make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • See quickstart guide for instructions

PR Testing (only if making code changes)

  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
    • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
    • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
    • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

Copy link

gitguardian bot commented Oct 17, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12819930 Triggered Generic Password 71ee7e7 tiltfiles/k8s/postgres/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@bryanchriswhite bryanchriswhite marked this pull request as ready for review October 21, 2024 11:52
@Olshansk
Copy link
Member

@bryanchriswhite This is in progress but also ready for review and has no reviewers and requires an investigation in [1].

Can you summarize the next step/blocker?

[1] https://github.com/tilt-dev/tilt-extensions/tree/master/git_resource

@bryanchriswhite
Copy link
Contributor Author

@Olshansk the TODO_INVESTIGATE is not urgent and can be committed for now. I've requested review from @okdas, and @jorgecuesta and @Alann27.

Copy link
Member

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gco chore/tilt && tilt up worked from the first try 😍 Thank you!

LGTM. I do think we need to document both tilt up and tilt down somewhere, though. How about README.md?

@bryanchriswhite
Copy link
Contributor Author

@okdas yes, we should definitely document how to use tilt. My thinking was to do that in a subsequent PR, in which we also remove the docker compose based environments and scripts. The immediate intention here is to support pokt-network/poktroll#885.

@bryanchriswhite
Copy link
Contributor Author

bryanchriswhite commented Oct 23, 2024

@okdas I added a section to the README and made it "parallel" with the docker-compose option for now.

@bryanchriswhite bryanchriswhite merged commit 68ff6a5 into main Oct 23, 2024
3 of 4 checks passed
@bryanchriswhite bryanchriswhite deleted the chore/tilt branch October 23, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants