-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Integrate Tilt development environment #23
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
12819930 | Triggered | Generic Password | 71ee7e7 | tiltfiles/k8s/postgres/values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
453735a
to
6b76580
Compare
@bryanchriswhite This is Can you summarize the next step/blocker? [1] https://github.com/tilt-dev/tilt-extensions/tree/master/git_resource |
@Olshansk the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gco chore/tilt && tilt up
worked from the first try 😍 Thank you!
LGTM. I do think we need to document both tilt up
and tilt down
somewhere, though. How about README.md
?
@okdas yes, we should definitely document how to use tilt. My thinking was to do that in a subsequent PR, in which we also remove the docker compose based environments and scripts. The immediate intention here is to support pokt-network/poktroll#885. |
@okdas I added a section to the README and made it "parallel" with the docker-compose option for now. |
Summary
Integrate Tilt (and k8s/helm) development environment.
Run:
Issue
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist