Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Supplier] refactor: SupplierStakingFee var usage to param usage #948

Open
wants to merge 1 commit into
base: todo_beta/params/supplier_staking_fee
Choose a base branch
from

Conversation

bryanchriswhite
Copy link
Contributor

Summary

Replace usage of supplierkeeper.SupplierStakingFee with the new param and delete it.

Issue

  • TODO_BETA

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added supplier Changes related to the Supplier actor governance Governance related changes on-chain On-chain business logic devnet-test-e2e consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Nov 21, 2024
@bryanchriswhite bryanchriswhite self-assigned this Nov 21, 2024
@bryanchriswhite bryanchriswhite changed the title [Service] refactor: SupplierStakingFee var usage to param usage [Supplier] refactor: SupplierStakingFee var usage to param usage Nov 21, 2024
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 948)
Grafana network dashboard for devnet-issue-948

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Nov 21, 2024
@bryanchriswhite bryanchriswhite changed the title [Supplier] refactor: SupplierStakingFee var usage to param usage [Supplier] refactor: SupplierStakingFee var usage to param usage Nov 21, 2024
@bryanchriswhite bryanchriswhite force-pushed the todo_beta/refactor/supplier_staking_fee branch from e9a59c6 to 643f058 Compare November 21, 2024 20:57
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 21, 2024 20:58
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. devnet devnet-test-e2e governance Governance related changes on-chain On-chain business logic push-image CI related - pushes images to ghcr.io supplier Changes related to the Supplier actor
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants