Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Health] fix: application module gRPC status error returns #954

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Code Health] fix: application module gRPC status error returns #954

wants to merge 7 commits into from

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Nov 22, 2024 •
edited
Loading

Summary

Ensure all application message and query handlers return gRPC status errors.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added application Changes related to the Application actor on-chain On-chain business logic devnet-test-e2e consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Nov 22, 2024
@bryanchriswhite bryanchriswhite self-assigned this Nov 22, 2024
@github-actions GitHub Actions
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 954)
Grafana network dashboard for devnet-issue-954

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Nov 22, 2024
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 22, 2024 10:58
This was referenced Nov 22, 2024
Open
Open
@bryanchriswhite bryanchriswhite marked this pull request as draft November 22, 2024 11:08
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 25, 2024 14:58
@bryanchriswhite bryanchriswhite requested review from red-0ne and removed request for red-0ne November 25, 2024 14:58
red-0ne
red-0ne approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question w.r.t. wrapped errors, otherwise LGTM

x/application/keeper/query_application.go
@@ -25,7 +28,8 @@ func (k Keeper) AllApplications(ctx context.Context, req *types.QueryAllApplicat
pageRes, err := query.Paginate(applicationStore, req.Pagination, func(key []byte, value []byte) error {
var application types.Application
if err := k.cdc.Unmarshal(value, &application); err != nil {
return err
logger.Error(fmt.Sprintf("unmarshaling application with key (hex): %x: %+v", key, err))
return status.Error(codes.Internal, err.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given all Internal errors were wrapping the original one, shouldn't this one do the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne red-0ne approved these changes

Assignees

@bryanchriswhite bryanchriswhite

Labels
application Changes related to the Application actor consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. devnet devnet-test-e2e on-chain On-chain business logic push-image CI related - pushes images to ghcr.io
Projects
Shannon
Status: 👀 In review
Milestone
Shannon Quality of Life
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanchriswhite @red-0ne