Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCM Asset Metadata #125

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mrshiposha
Copy link

This is a refined version of the XCM Asset Metadata RFC.

This PR supersedes the PR opened in the xcm-format repository following the migration of XCM RFCs to the Fellowship RFCs.

Summary

This RFC proposes a metadata format for XCM-identifiable assets (i.e., for fungible/non-fungible collections and non-fungible tokens) and a set of instructions to communicate it across chains.

Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

text/0125-xcm-asset-metadata.md Outdated Show resolved Hide resolved
text/0125-xcm-asset-metadata.md Outdated Show resolved Hide resolved
@anaelleltd anaelleltd added the Proposed Is awaiting 3 formal reviews. label Nov 3, 2024
Copy link
Contributor

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe explicit define MetadataMap and MetadataKeys

type MetadataKey = Vec<u8>;
type MetadataValue = Vec<u8>;
type MetadataMap = BTreeMap<MetadataKey, MetadataValue>;
type MetadataKeys = BTreeSet<MetadataKey>; // or call it MetadataKeySet?

text/0125-xcm-asset-metadata.md Outdated Show resolved Hide resolved
text/0125-xcm-asset-metadata.md Outdated Show resolved Hide resolved
@xlc
Copy link
Contributor

xlc commented Dec 13, 2024

Let me know if you want me to put this for onchain voting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposed Is awaiting 3 formal reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants