Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable MBM migrations for all runtimes for check-migrations CI #590

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Disable MBM migrations for all runtimes for check-migrations CI #590

wants to merge 9 commits into from

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Feb 12, 2025

Relates to: paritytech/try-runtime-cli#109

MBM migrations are not set up for any runtimes, but only Encointer has disabled checks for them.

  • Does not require a CHANGELOG entry

@bkontur
Copy link
Contributor Author

bkontur commented Feb 13, 2025

@ggwpez what do you suggest here? Wait for fix paritytech/try-runtime-cli#109 or merge this PR?

@bkchr
Copy link
Contributor

bkchr commented Feb 13, 2025

Why? Did we had any failing tests because of this?

@ggwpez
Copy link
Member

ggwpez commented Feb 13, 2025

@ggwpez what do you suggest here? Wait for fix paritytech/try-runtime-cli#109 or merge this PR?

I guess we have to merge this so that the tests run again properly. There is still no real maintainer of the try-runtime-cli, only a part-time one that has no availability until EOM.

@bkchr
Copy link
Contributor

bkchr commented Feb 14, 2025

/cmd bench --runtime coretime-kusama --pallet pallet_xcm

@bkchr
Copy link
Contributor

bkchr commented Feb 14, 2025

@bkontur just abusing your pr a little bit :P

@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-kusama --pallet pallet_xcm" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-kusama --pallet pallet_xcm" has failed ❌! See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Feb 14, 2025

Command "bench --runtime coretime-kusama --pallet pallet_xcm" has failed ❌! See logs here

@mordamax I think this subweight comparision should compare PR's branch against the PR's target/base branch here: https://github.com/polkadot-fellows/runtimes/blob/main/.github/workflows/cmd.yml#L351

because now it compares to the origin/main, which is in my fork, but it is not up-to-date - so tthat is why there is so big output for every pallet/runtime
https://github.com/polkadot-fellows/runtimes/actions/runs/13330241520/job/37234272415#step:15:10

So here: https://github.com/polkadot-fellows/runtimes/blob/main/.github/workflows/cmd.yml#L351 we should change refs/remotes/origin/main for something which points to the actual PR's target branch

@bkontur
Copy link
Contributor Author

bkontur commented Feb 14, 2025

/cmd bench --runtime coretime-kusama --pallet pallet_xcm

@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-kusama --pallet pallet_xcm" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-kusama --pallet pallet_xcm" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs force_xcm_version 109.49us 116.36us +6.28
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs take_response 163.85us 173.93us +6.15

@bkontur
Copy link
Contributor Author

bkontur commented Feb 14, 2025

@mordamax @bkchr very nice, looks like the bot finally passed :), but we need to fix this: #590 (comment)

@mordamax
Copy link
Contributor

@bkontur it definitely needs improvements, as it was first attempt here, and never worked to test&iterate. Feel free to change it :)

the polkadot-sdk one is a bit more advanced and stable

@bkontur
Copy link
Contributor Author

bkontur commented Feb 18, 2025

@bkontur it definitely needs improvements, as it was first attempt here, and never worked to test&iterate. Feel free to change it :)

the polkadot-sdk one is a bit more advanced and stable

@mordamax
This is as far as I can go for now: paritytech/polkadot-sdk#7602 😃

@bkontur
Copy link
Contributor Author

bkontur commented Feb 22, 2025

/cmd bench --runtime coretime-polkadot coretime-polkadot --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic

@github-actions GitHub Actions
Copy link

Command "" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

Command "" has finished ✅ See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Feb 22, 2025

/cmd bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic

@github-actions GitHub Actions
Copy link

Command "" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

Command "" has finished ✅ See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Feb 22, 2025

/cmd bench --runtime coretime-polkadot --pallet pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic

@github-actions GitHub Actions
Copy link

Command "" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

Command "" has finished ✅ See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Feb 22, 2025

/cmd bench --runtime coretime-polkadot --pallet pallet_xcm

@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-polkadot --pallet pallet_xcm" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-polkadot --pallet pallet_xcm" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs force_xcm_version 109.49us 116.36us +6.28
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs take_response 163.85us 173.93us +6.15
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs execute 39.50us 36.71us -7.07
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs force_default_xcm_version 3.24us 2.84us -12.35

@bkontur
Copy link
Contributor Author

bkontur commented Feb 24, 2025

/cmd bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm

@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs claim_assets 200.25us 221.95us +10.84
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs take_response 156.65us 170.73us +8.99
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs execute 42.28us 38.16us -9.74

@bkontur
Copy link
Contributor Author

bkontur commented Feb 24, 2025

/cmd bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm pallet_balances

@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm pallet_balances" has started 🚀 See logs here

@actions-user
Update from bkontur running command 'bench --runtime coretime-polkado…
fcea384 
…t coretime-kusama --pallet pallet_xcm pallet_balances'
@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm pallet_balances" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
system-parachains/coretime/coretime-kusama/src/weights/pallet_balances.rs force_adjust_total_issuance 33.12us 37.46us +13.10
system-parachains/coretime/coretime-kusama/src/weights/pallet_balances.rs force_unreserve 147.12us 157.60us +7.12
system-parachains/coretime/coretime-kusama/src/weights/pallet_balances.rs transfer_all 184.80us 195.06us +5.55
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs execute 42.28us 40.13us -5.09
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs execute 39.50us 36.75us -6.96
system-parachains/coretime/coretime-polkadot/src/weights/pallet_balances.rs burn_allow_death 37.34us 33.68us -9.80
system-parachains/coretime/coretime-polkadot/src/weights/pallet_balances.rs burn_keep_alive 25.60us 23.01us -10.12
system-parachains/coretime/coretime-polkadot/src/weights/pallet_balances.rs force_adjust_total_issuance 7.73us 6.51us -15.78
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs force_default_xcm_version 3.24us 2.65us -18.21

@bkontur
Copy link
Contributor Author

bkontur commented Feb 24, 2025

/cmd bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm pallet_balances pallet_xcm_benchmarks::fungible

@github-actions GitHub Actions
Copy link

Command "" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

Command "" has finished ✅ See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Feb 24, 2025

/cmd bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm pallet_balances

@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm pallet_balances" has started 🚀 See logs here

@actions-user
Update from bkontur running command 'bench --runtime coretime-polkado…
56b39d1 
…t coretime-kusama --pallet pallet_xcm pallet_balances'
@github-actions GitHub Actions
Copy link

Command "bench --runtime coretime-polkadot coretime-kusama --pallet pallet_xcm pallet_balances" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs force_default_xcm_version 3.24us 6.71us +107.10
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs execute 39.50us 48.63us +23.11
system-parachains/coretime/coretime-polkadot/src/weights/pallet_balances.rs burn_allow_death 37.34us 43.05us +15.29
system-parachains/coretime/coretime-kusama/src/weights/pallet_balances.rs transfer_allow_death 185.61us 212.44us +14.46
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs claim_assets 202.68us 231.07us +14.01
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs take_response 163.85us 182.04us +11.10
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs teleport_assets 387.05us 427.49us +10.45
system-parachains/coretime/coretime-polkadot/src/weights/pallet_balances.rs transfer_allow_death 188.37us 202.94us +7.74
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs take_response 156.65us 168.58us +7.62
system-parachains/coretime/coretime-polkadot/src/weights/pallet_xcm.rs claim_assets 200.25us 211.53us +5.63
system-parachains/coretime/coretime-kusama/src/weights/pallet_xcm.rs execute 42.28us 38.65us -8.59
system-parachains/coretime/coretime-polkadot/src/weights/pallet_balances.rs force_adjust_total_issuance 7.73us 6.53us -15.52

@bkontur bkontur mentioned this pull request Feb 24, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bkontur @bkchr @ggwpez @mordamax @actions-user