Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Filters with Null default parameters #30

Open
polyfractal opened this issue Apr 4, 2013 · 1 comment
Open

Refactor Filters with Null default parameters #30

polyfractal opened this issue Apr 4, 2013 · 1 comment
Milestone
0.2.0 Release

Comments

@polyfractal
Copy link
Owner

Defaults are hardcoded into filters, basically as best guesses taken from the Perl client. Would be much better to just pass Null and let ES use the internal defaults.

This also reduces maintenance, since ES defaults can change and they will automatically propagate to Sherlock without any changes on our end.

Related to #27
@polyfractal
Copy link
Owner Author

Quick update on this: ES devs say that while Null may work, it is probably not the best solution. There are a few locations (notably "upsert" in the Update operations) where a Null is actually parsed and throws crazy errors.

They advised that parameters only be sent to ES when they are actually set. Which means considerably more work for me :(

@polyfractal polyfractal mentioned this issue May 28, 2013
Closed
polyfractal added a commit that referenced this issue May 30, 2013
@polyfractal
Add paramsToArray()
c78dafb 
This method take an array of parameters, checks if they
they are set in the $this->param list and returns a composed
array.

This will be used for all components so that defaults do
not need to be set, and so that null is not passed in
request bodies to ES.

Related to #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0 Release
Development

No branches or pull requests
1 participant
@polyfractal