-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Official Client #87
Comments
Sorry for the delay, got caught up with other stuff at work. You mentioned in the other thread that you were already modifying Sherlock to integrate the official client? I won't have time to do the integration myself (and Sherlock has already suffered a lot of bit-rot because of my negligence). But I would definitely help provide guidance on a PR to get it integrated, and help out whenever I have time. |
Yes, I was working on search requests. Right now, I have some other things in my hand but I will begin to work on this integration, again. After I have done with search request, I can make a PR and you can comment on that or after I finished all the integration stuff, I can make a PR. I guess I prefer second one, but I am not that sure. Maybe it is a good idea that discussing earlier on a small part. |
Sorry, I couldn't spend much time to this job, so it is still incomplete. I've done much of the integration stuff and updated tests. There are some works such as response classes, API updates etc. So, I did not make a PR because of these unfinished works. You can check my fork and make comments when you are available. |
Hi, I was looking for a fluent builder for elasticSearch and a fall across this repo and issue. Do you think it is still and interesting feature on top of the official client ? Does the work to do after 3 years wouldn't be huge ? |
As discussed here, official client will remain as a low level library. And Sherlock's fluent API is very useful and clean. So, It would be good if Sherlock supports official client.
The text was updated successfully, but these errors were encountered: