-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escaping of reserved words in schema name #32
Comments
I am watching this bug and what's the best solutions :
|
Hi @stood, I vote for he first solution. The generator should always escape. But why not the relation name too? This way, there wouldn't be the need to maintain a reserved keyword list. Uppercase relation names would safely work too (perhaps they already do, I don't know). |
Hi @tlode I'm agree with you |
yes, this is an issue in itself, but re-factoring this means changing Cli, PommBundle and PommModule so we will wait for the next release branch to do that. |
The commits have been rollbacked. They induce hard to track problems in projections and embedded entities. This problem will be addressed in the 2.1 release as it requires a bit of refactoring. |
If we create schema with name "user" cli generator should create relations with escaped schema name as it's reserved word. E.g.
AutoStructure/Table.php should contains ->setRelation('"user".table') instead of ->setRelation('user.table')
The text was updated successfully, but these errors were encountered: