Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generator in iterator extraction #97

Open
chanmix51 opened this issue May 29, 2017 · 1 comment
Open

Use generator in iterator extraction #97

chanmix51 opened this issue May 29, 2017 · 1 comment
Labels
easy improvement
Milestone
2.1

Comments

@chanmix51
Copy link
Member

The extract() method in result iterator stores all the result in an array, this uses a lot of memory. It would be better to use a generator here (PHP 5.5).
@chanmix51 chanmix51 added this to the 2.1 milestone Jul 11, 2017
@stood stood mentioned this issue Dec 1, 2017
Closed
@chanmix51
Copy link
Member Author

To sum it up: the result iterator proposes a extract() method to materialize the result set as an array (to use mainly with json_encode). Why then use extract if an iterator (or a generator) is needed? Why not directly use the iterator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy improvement
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
1 participant
@chanmix51