Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review #4 #4

Open
dangoldin opened this issue Apr 25, 2015 · 0 comments
Open

Code Review #4 #4

dangoldin opened this issue Apr 25, 2015 · 0 comments

Comments

@dangoldin
Copy link

Sorry this is so late.

  • Nice job using existing methods to find the index but you can see if you can implement it on your own using iteration.
  • Your Main.java is entirely empty and doesn't do anything right now. Good idea to keep your code clean and minimal so it's less confusing for others.
  • Clever job using regex to sanitize the HTML! You can also see how it can get very complicated very quickly though so very important to test it.
  • Great idea to use a HashMap for the distribution calculation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dangoldin