Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use radius_s for NavBar toggle #747

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Use radius_s for NavBar toggle #747

merged 2 commits into from
Dec 25, 2024

Conversation

git-f0x
Copy link
Contributor

@git-f0x git-f0x commented Dec 5, 2024

This makes the NavBar toggle use radius_s for the button radius, to match designs. Adding a new enum value just for that feels a bit messy, but using Button::Custom feels potentially messier (and I'm not entirely sure how to do it). This could be removed if it's decided to use radius_s for all header bar buttons in the future.
Introduces a horizontal_padding field to the header bar, which is needed for the padding offset, but can also be used by cosmic-comp to make window controls more centered in the SSD corners. Though this can be removed if it'll be eventually possible to set the borders on individual container sides, which would remove the need for the offset, and if SSDs should have the same horizontal padding of 8 as apps. I removed this, since it caused the header elements to be off-center at the corners.

Also fixes #743.

Edit: Also makes the styling of the dropdown closer to designs.

@git-f0x git-f0x marked this pull request as draft December 5, 2024 20:26
@git-f0x git-f0x changed the title Use radius_s for HeaderBar button style Use radius_s for NavBar toggle Dec 5, 2024
@git-f0x git-f0x marked this pull request as ready for review December 5, 2024 20:59
@git-f0x git-f0x force-pushed the master branch 2 times, most recently from cf60807 to 4e1933c Compare December 5, 2024 21:19
@mmstick mmstick merged commit 58fc034 into pop-os:master Dec 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dropshadow from the ContextDrawer
2 participants