Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv: Allow reflowing for narrow width #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Nov 19, 2021

As suggested on pop-os/gnome-control-center#202.

Will require update to desktop widget with this version to apply on hirsute/impish.

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing the Appearance page in GNOME Initial Setup to be too large vertically:
Screenshot from 2021-11-22 10-18-24
Can't test the actual reflowing behavior since GNOME Initial Setup does not resize (and desktop-widget in Settings is not using this branch.)

@ids1024
Copy link
Member Author

ids1024 commented Nov 29, 2021

(and desktop-widget in Settings is not using this branch.)

If you test with pop-os/desktop-widget#73, it pulls in this version.

Doesn't seem to have that issue in Gnome Control Center. Not sure how Gnome Initial Setup differs...

@ids1024
Copy link
Member Author

ids1024 commented Nov 30, 2021

Ah, of course the problem is that GtkFlowBox doesn't behave as one might expect unless it's in a GtkScrolledWindow: https://gitlab.gnome.org/GNOME/gtk/-/issues/897

A gtk::ScrolledWindow with both horizontal and vertical scrolling disabled seems to have the same issue. It may be possible to address this by subclassing/wrapping gtk::FlowBox with custom size allocation, though I'm not sure it's worthwhile.

Edit: The fact that gtk's maintainers don't seem to consider this worth implementing in FlowBox likely suggests it's not that simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants