Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOMContentLoaded generates errors client-side #66

Open
AylenHoz opened this issue Feb 13, 2025 · 0 comments · May be fixed by #65
Open

DOMContentLoaded generates errors client-side #66

AylenHoz opened this issue Feb 13, 2025 · 0 comments · May be fixed by #65

Comments

@AylenHoz
Copy link
Contributor

AylenHoz commented Feb 13, 2025 •
edited
Loading

Package version

4.1.0-beta.5

Describe the bug

Issue description

In this commit, the DOMContentLoaded event was introduced. This new implementation generates client-side errors because it depends on the page lifecycle, and sometimes the event occurs but is not dispatched.

Solution

Add an event wrapper that checks the document state before adding the event listener or executing it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add or execute DOMContentLoaded events based on document state AylenHoz/youch
1 participant
@AylenHoz