Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust HTML styles for small screens #67

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

Adjust HTML styles for small screens #67

wants to merge 2 commits into from

Conversation

AylenHoz
Copy link
Contributor

@AylenHoz AylenHoz commented Feb 13, 2025 •
edited
Loading

🔗 Linked issue

closes #68

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Some HTML styles are not suitable for small screens, such as those on mobile devices:

  • Some padding is too large
  • The stack trace ellipsis is lost on small screens

Solution: Implement styles based on calc and media query to adjust certain styles to the screen size.

Before - After

WhatsApp Image 2025-02-13 at 11 22 47 (1)
WhatsApp Image 2025-02-13 at 11 22 47

📝 Checklist

  • I have read the contribution guide.
  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@AylenHoz AylenHoz mentioned this pull request Feb 13, 2025
Open
@AylenHoz
Copy link
Contributor Author

I don't know why windows test failed if all tests passed

@thetutlage
Copy link
Member

They should pass now if you rebase your branch

@AylenHoz AylenHoz changed the title Adjust HTML styles for smal screens Adjust HTML styles for small screens Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some HTML styles are not suitable for small screens
2 participants
@AylenHoz @thetutlage