Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Templates regression since 2.22.0 #12337

Open
2 tasks done
slym opened this issue Oct 18, 2024 · 5 comments
Open
2 tasks done

App Templates regression since 2.22.0 #12337

slym opened this issue Oct 18, 2024 · 5 comments
Labels

Comments

@slym
Copy link

slym commented Oct 18, 2024

Before you start please confirm the following.

Problem Description

Custom App Templates JSON using version 2 format does not work correctly since Portainer 2.22.

List of templates is loaded correctly in UI but I'm unable to open them. It starts to display the template settings but 1 second after the UI goes back to the list. The issue seems related to the new "id" parameters that appeared with App Templates v3.

Another issue is that App Templates V3 is not currently documented anywhere (or I could not find its documentation).

Expected Behavior

App templates v2 and v3 should work correctly in all recent versions of Portainer.

Actual Behavior

List is loading correctly but not the Template details and options page.

Steps to Reproduce

I did some extended testings and it shows some clear regressions since 2.22.0 :

Portainer version V2 V2 with ID V3 V3 without ID
2.23 KO KO Works KO
2.22.0 KO KO Works KO
2.21.3 Works Works Works Works
2.20.3 Works Works Works Works

App Templates files used :

You just have to point to these URL to reproduce the behaviour (not loading details page on any Template).

Portainer logs or screenshots

Most of the time there is no error, it just goes back to the list after selecting a template.
Sometimes there is an error in the events :
image

Portainer version

2.23.0

Portainer Edition

Business Edition (BE/EE) with 5NF / 3NF license

Platform and Version

Any version

OS and Architecture

Any OS

Browser

Chrome 114.0

What command did you use to deploy Portainer?

standard command and tried on multiple setups always with same result.

Additional Information

It would be great to fix the regression because I have dozens of Portainer CE pointing to my templates and they are managed by other users so I can't control their Portainer versions.

App templates JSON v3 must be documented correctly somewhere.

@Xantha123
Copy link

I can confirm this. i have the exact same problems with templates. In buisiness and the community version on 2 differt machines setup using Truenas Scale.

@TomChantler
Copy link

I have just found this issue because I have exactly the same problem. I'm running TrueNAS Scale 24.10 (ElectricEel-24.10.0.2), running Portainer Business Edition 2.23.0. When I click on an app template to install, the config screen pops up for about a nanosecond and then returns me to the list of templates.

@ralfrupf1976
Copy link

Same problem here - using STS - current Version 2.24.0
Templates from https://raw.githubusercontent.com/Lissy93/portainer-templates/main/templates.json

@TomChantler
Copy link

I actually wrote a simple script to fix those templates and then opened a pull request on that repo with my fixed version: Lissy93/portainer-templates#67. Note that I didn't alter the original file, I created a new one called templates_v3.json. I'm just using the raw file link from my own repo in my Portainer installation: https://raw.githubusercontent.com/TomChantler/portainer-templates/refs/heads/v3/templates_v3.json. It works fine. Try it yourself.

@jon4god
Copy link

jon4god commented Nov 30, 2024

https://raw.githubusercontent.com/TomChantler/portainer-templates/refs/heads/v3/templates_v3.json

Yeah, that option works! I wonder if there will be an update to the main branch?

JourneyOver added a commit to JourneyOver/selfhosted_templates that referenced this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants
@slym @TomChantler @jon4god @Xantha123 @ralfrupf1976 and others