Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laser button not updated to off when switching off laser at the end of the experiment #47

Open
vigji opened this issue Jul 15, 2020 · 8 comments · Fixed by #45
Open
Assignees
Labels
bug Something isn't working

Comments

@vigji
Copy link
Member

vigji commented Jul 15, 2020

No description provided.

@vigji vigji added the bug Something isn't working label Jul 15, 2020
@vigji
Copy link
Member Author

vigji commented Jul 15, 2020

On a not so related note: now it seems that noise subtraction is reverted at the end of each experiment, is that intentional? Can it be disabled?

@diegoasua
Copy link
Member

Noise subtraction should stay on unless you change any camera property. Does it deactivate at the end of the experiment or do you actually change any property?

@diegoasua
Copy link
Member

The laser widget update has been added to pull request #45

@vigji
Copy link
Member Author

vigji commented Jul 15, 2020

Noise subtraction should stay on unless you change any camera property. Does it deactivate at the end of the experiment or do you actually change any property?

I don't change any camera property, when I abort the experiment or it finishes it throws the popup telling me that calibration was deactivated.

@diegoasua
Copy link
Member

I'll have a look at this. Probably is a one liner fix

@diegoasua
Copy link
Member

Noise subtraction kept on at experiment end has now been also added to pull request #45. Thanks for spotting this Luigi

@diegoasua
Copy link
Member

In the new sashimi this is again an issue. To be looked at

@diegoasua
Copy link
Member

On a not so related note: now it seems that noise subtraction is reverted at the end of each experiment, is that intentional? Can it be disabled?

I can't reproduce this in scope detached mode anymore. At some point we may have solved this. Only thing that does not work well is, when deactivating noise subtraction the pop up notification does not show up. If we do as you proposed in #101 this could be easily managed. Also that would make room for emitting a signal at the end of the experiment - many different parts of the GUI need this info to update this and that and currently they do so in an extremely ugly, error-prone way (like it is demonstrated by the noise subtraction glitch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants