Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap components that require scrolling in a Scrollable component #5472

Open
timtmok opened this issue Nov 22, 2024 · 0 comments
Open

Wrap components that require scrolling in a Scrollable component #5472

timtmok opened this issue Nov 22, 2024 · 0 comments
Labels
area: workbench Issues related to Workbench category. enhancement New feature or request
Milestone

Comments

@timtmok
Copy link
Contributor

timtmok commented Nov 22, 2024

For Positron in the Web, the wheel event is listened to in order to drop the event. This prevents users from using gestures to navigate to another URL. This causes problems with Positron UI components where scrolling doesn't work.

Wrapping our components in a Scrollable can get around this problem. It uses VS Code's scrollable code, which handles the wheel event and allows scrolling. This does have limitations where the Scrollable does need to know the width & height as well as scroll width & height but will probably be fine.

The Console and interpreter dropdown already have this fixed with a workaround. The Plots view already uses a Scrollable. Anything that uses PositronModalPopup might be fine since it has the workaround but it does not guarantee child components can scroll.

Any of the views likely need a fix if their contents require scrolling. For example, fhe Variables view currently does not scroll in web.

@timtmok timtmok added area: workbench Issues related to Workbench category. enhancement New feature or request labels Nov 22, 2024
@timtmok timtmok added this to the Future milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: workbench Issues related to Workbench category. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant