Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frequent extensions host crashes on Positron for Posit Workbench: renderer closed the socket #5508

Open
jmcphers opened this issue Nov 25, 2024 · 0 comments
Open

Frequent extensions host crashes on Positron for Posit Workbench: renderer closed the socket #5508

jmcphers opened this issue Nov 25, 2024 · 0 comments
Labels
area: workbench Issues related to Workbench category.

Comments

@jmcphers
Copy link
Collaborator

We're observing frequent crashes in the extension host in Positron for Posit Workbench. These don't seem to happen in VS Code.

Some logs from @jthomasmock suggest that the problem is that the "renderer closed the socket". Here is the relevant bit of the logs, showing where extension host pid 7642 terminated and was restarted with a new pid 7804.

Extension host terminations and restarts are annoying but Positron has machinery to survive them. However they create a lot of disruption in the end user experience and make things look flaky (see e.g. #5444). In addition, we have observed situations in which Positron does not successfully sort things out after the extension host terminates.

Because we have only seen these errors on Workbench, the fact that they are happening due to a closed socket suggests that there maybe an SSL or connectivity issue in play.

2024-11-25 20:38:12.817 [info] Extension host terminating: renderer closed the socket
2024-11-25 20:38:12.824 [info] Lock '/home/thomas/.positron-server/User/workspaceStorage/6d8b9e70/vscode.lock': Marking the lockfile as scheduled to be released in 6000 ms.
2024-11-25 20:38:12.899 [error] Canceled: Canceled
	at Object.$0 (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:1185:23)
	at /usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:66288:43
	at Array.forEach (<anonymous>)
	at $Brc.dispose (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:66285:33)
	at $hGc.terminate (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:99848:20)
	at $JFc.terminate (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:102285:20)
	at onTerminate (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:110573:53)
	at Socket.<anonymous> (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:110417:21)
	at Socket.emit (node:events:531:35)
	at Pipe.<anonymous> (node:net:338:12) setContext undefined
2024-11-25 20:38:12.899 [error] Canceled: Canceled
	at Object.$0 (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:1185:23)
	at /usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:66288:43
	at Array.forEach (<anonymous>)
	at $Brc.dispose (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:66285:33)
	at $hGc.terminate (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:99848:20)
	at $JFc.terminate (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:102285:20)
	at onTerminate (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:110573:53)
	at Socket.<anonymous> (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:110417:21)
	at Socket.emit (node:events:531:35)
	at Pipe.<anonymous> (node:net:338:12) setContext undefined
2024-11-25 20:38:12.900 [error] Canceled: Canceled
	at new $yrc (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:63761:22)
	at $Brc.U (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:66568:24)
	at target.<computed> (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:66379:41)
	at $_Q.g (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86285:54)
	at $_Q.executeCommand (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86241:25)
	at registration.registerCommand.description (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86206:51)
	at $_Q.h (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86319:39)
	at $_Q.g (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86250:29)
	at $_Q.executeCommand (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86241:25)
	at Object.executeCommand (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:104041:44)
	at zt.set (/usr/lib/rstudio-server/bin/positron-server/extensions/ms-toolsai.jupyter/dist/extension.node.js:304:165051)
	at Tb.dispose (/usr/lib/rstudio-server/bin/positron-server/extensions/ms-toolsai.jupyter/dist/extension.node.js:342:8136)
	at $Uc (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:4947:27)
	at /usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:100113:41
	at /usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:4992:17
	at Object.dispose (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:2363:29)
	at $hGc.eb (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:99979:38)
	at /usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:99826:33
	at Array.map (<anonymous>)
	at $hGc.$ (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:99825:51)
	at $hGc.terminate (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:99849:48)
	at $JFc.terminate (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:102285:20)
	at onTerminate (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:110573:53)
	at Socket.<anonymous> (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:110417:21)
	at Socket.emit (node:events:531:35)
	at Pipe.<anonymous> (node:net:338:12) setContext undefined
2024-11-25 20:38:12.910 [info] Eager extensions activated
2024-11-25 20:38:12.918 [error] Canceled: Canceled
	at new $yrc (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:63761:22)
	at $Brc.U (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:66568:24)
	at target.<computed> (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:66379:41)
	at $_Q.g (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86285:54)
	at $_Q.executeCommand (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86241:25)
	at registration.registerCommand.description (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86206:51)
	at $_Q.h (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86319:39)
	at $_Q.g (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86250:29)
	at $_Q.executeCommand (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:86241:25)
	at Object.executeCommand (/usr/lib/rstudio-server/bin/positron-server/out/vs/workbench/api/node/extensionHostProcess.js:104041:44)
	at s.executeCommand (/usr/lib/rstudio-server/bin/positron-server/extensions/positron-python/dist/client/extension.js:2:108194)
	at c.setContext (/usr/lib/rstudio-server/bin/positron-server/extensions/positron-python/dist/client/extension.js:2:116803)
	at I.updateTestUIButtons (/usr/lib/rstudio-server/bin/positron-server/extensions/positron-python/dist/client/extension.js:2:1019356)
	at I.activate (/usr/lib/rstudio-server/bin/positron-server/extensions/positron-python/dist/client/extension.js:2:1018265)
	at /usr/lib/rstudio-server/bin/positron-server/extensions/positron-python/dist/client/extension.js:2:2602
	at Array.map (<anonymous>)
	at v.activateWorkspace (/usr/lib/rstudio-server/bin/positron-server/extensions/positron-python/dist/client/extension.js:2:2592)
	at process.processTicksAndRejections (node:internal/process/task_queues:95:5) setContext undefined
2024-11-25 20:38:12.959 [info] Extension host with pid 7642 exiting with code 0
2024-11-25 20:38:18.326 [info] Extension host with pid 7804 started
@jmcphers jmcphers added the area: workbench Issues related to Workbench category. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: workbench Issues related to Workbench category.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmcphers