Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to delete a console tab #6311

Open
4 tasks
dhruvisompura opened this issue Feb 11, 2025 · 0 comments
Open
4 tasks

Add mechanism to delete a console tab #6311

dhruvisompura opened this issue Feb 11, 2025 · 0 comments
Labels
area: console Issues related to Console category. area: ui Issues related to UI category. enhancement New feature or request

Comments

@dhruvisompura
Copy link
Contributor

Add a trash can icon button to delete a console tab. This includes the session, and all associated console UI state for that session.

When a user clicks the trash can button for a console session tab:

1. Determine which session will be the new active session from the list of created sessions
2. Shutdown the session for the user if it hasn't already been done
3. Remove the session from all active session lists. We need to make sure the variables pane updates its list of sessions, and switches over to the new active session ONLY IF it was using the deleted session context.
4. Cleanup output channels? This may be out of scope.
5. Re-trigger diagnostics if the deleted console tab was the active tab

Testing

  • Verify code diagnostics, code completion are re-triggered when active session is deleted. The new session context should be used
  • Verify the console pane and interpreter dropdown updates its list of sessions shown to the user, and switches over to the new active session ONLY IF the deleted session was the foreground session.
  • Verify the variables pane updates its list of sessions, and switches over to the new active session ONLY IF it was using the deleted session context
  • Verify deleting a console tab triggers a graceful shutdown of the session and it is not hanging around by using the runtime debug pane
@dhruvisompura dhruvisompura added enhancement New feature or request area: console Issues related to Console category. area: ui Issues related to UI category. labels Feb 11, 2025
@dhruvisompura dhruvisompura added this to the 2025.03 Pre-Release milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: console Issues related to Console category. area: ui Issues related to UI category. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant