e2e test: update db connections test #5454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testlabauto
reviewed
Nov 22, 2024
| this.deleteConnectionButton = code.driver.page.getByLabel('Delete Connection'); | ||
| this.disconnectButton = code.driver.page.getByLabel('Disconnect'); | ||
| this.connectIcon = code.driver.page.locator('.codicon-arrow-circle-right'); | ||
| this.connectionItems = code.driver.page.locator('.connections-list-item'); |
There was a problem hiding this comment.
Nitpick, but I think Nick prefers just putting these outside the constructor since they are static.
There was a problem hiding this comment.
I could do that, but they are dependent on this.code.driver.page since they are Locators and not just a string. which means I won't be able to use them like this in the test:
await app.workbench.positronConnections.disconnectButton.click();
There was a problem hiding this comment.
I thought locators were just static pointers to what would be used to find an element once they are used?
There was a problem hiding this comment.
Its really a nitpick... just keeping you in the loop regarding what Nick had mentioned perfering.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Update the existing database connections test to support the new DB connections pane changes by toggling the appropriate feature flag (which restarts the app) and updating the test logic accordingly.
Approach
Modify the database connections test to use the new fixture and update all locators and methods to interact with the updated connections pane.
QA Notes
You might be wondering what those
test.stepsare there for? They make the HTML report easier to read like so:If you forget what it looks before, it was this nonsense:
I think this will be a little bit of an art. They are optional and you certainly don't want them for every single line of code, but it does help lump steps together to ease debugging of reports. Note: the trace viewer will not show them grouped like the report does.