Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression] Mypy fails with shiny==1.0.0 #1649

Closed
mccauleyp opened this issue Aug 27, 2024 · 0 comments · Fixed by #1650
Closed

[regression] Mypy fails with shiny==1.0.0 #1649

mccauleyp opened this issue Aug 27, 2024 · 0 comments · Fixed by #1650
Assignees
@schloerke
Labels
bug Something isn't working
Milestone
v1.1.0

Comments

@mccauleyp
Copy link

Seems like the same issue was fixed before but crept back in: #1332

Shiny is incompatible with mypy:

% mypy .
venv/lib/python3.11/site-packages/shiny/render/_data_frame_utils/_selection.py:154: error: invalid syntax  [syntax]
Found 1 error in 1 file (errors prevented further checking)

Unfortunately seems like it's not possible to edit one's mypy configuration to get past a syntax error in a dependency.

I'm working around it by just deleting line 154 of _selection.py for now.
@schloerke schloerke added bug Something isn't working and removed needs-triage labels Aug 27, 2024
@schloerke schloerke self-assigned this Aug 27, 2024
@schloerke schloerke added this to the v1.0.1 milestone Aug 27, 2024
@schloerke schloerke mentioned this issue Aug 27, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schloerke schloerke

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

bug: Verify mypy can run on CI posit-dev/py-shiny
2 participants
@schloerke @mccauleyp