Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change max replica calc to only include initContainer for rolling out pods #17

Open
druppelt opened this issue Sep 11, 2024 · 1 comment

Comments

@druppelt
Copy link

Currently the calculation assumes that e.g. 3 replicas + 1 pod overhead for rolling rollout needs the resources for 4 initContainers.
My understanding is, that for a given pod the init resources will never be needed simultaneous to the container resources. So for this example the normally running containers should not include the initContainer and the overhead over normal replicas should only be either the init container or the normal containers, whatever is bigger.

As it doesn't seem like this is beeing maintained I created my own fork, in which I plan to implement this.
Should I be mistaken, please let me know and I'll create pull requests.

druppelt added a commit to druppelt/kuota-calc that referenced this issue Sep 14, 2024
For normally running pods init containers can be ignored. During init phase of a pod, so before it becomes ready, either the init or normal containers are running. Use the highest value of both for each resource. Use these `MaxResources` for all non-ready pods.
Refs: postfinance#17
@druppelt
Copy link
Author

This is implemented in v0.3.4 of my fork. I'll keep the issue open until this is merged into this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant