Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: wrong maxReplicas for rolling updates #20

Open
druppelt opened this issue Sep 14, 2024 · 1 comment
Open

Bug: wrong maxReplicas for rolling updates #20

druppelt opened this issue Sep 14, 2024 · 1 comment

Comments

@druppelt
Copy link

The max replicas should be replicas+maxSurge. Instead kuota-calc uses replicas+maxSurge-maxUnavailable. For a mostly stock Deployment with 10 replicas this means that there will be max 13 replicas, but kuota calc outputs 11.
This is both from my understanding of the kubernetes docs and a local test using the kubernetes install shipping with docker desktop.
druppelt added a commit to druppelt/kuota-calc that referenced this issue Sep 14, 2024
@druppelt
fix: correctly calculate maxReplicas for rollingUpdate deployments & …
86c2709 
…rolling DeploymentConfigs

Correctly calculate the maxReplicas as `replicas + maxSurge` instead of `replicas + maxSurge - maxUnavailable`

Refs: postfinance#20
@druppelt
Copy link
Author

This is implemented in v0.3.3 of my fork. I'll keep the issue open until this is merged into this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@druppelt