Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-200 requests #7

Open
johnholdun opened this issue May 24, 2019 · 0 comments
Open

Handle non-200 requests #7

johnholdun opened this issue May 24, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@johnholdun
Copy link
Contributor

When features that involve fetching external documents receive unexpected responses, their behavior should change. Generally, this means that they should fall back to working like regular, unenhanced links and forms.

For example, if an inline link fetches a URL that returns a response with a status code in the 400 or 500 range, it should just display the full response as if the user clicked a regular link, as we cannot ensure that the targeted elements actually exist on the page or that the fetched content can reliably be rendered on the current page. An embed that returns a 400+ response should do nothing, leaving the enhanced link on the page for the user to click if they so desire.

300 requests should probably be followed, which is the default behavior when using fetch, so there's no work to be done here.

@johnholdun johnholdun added the enhancement New feature or request label May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant