Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome - browser notifications #132

Open
slaFFik opened this issue Nov 8, 2017 · 2 comments
Open

Chrome - browser notifications #132

slaFFik opened this issue Nov 8, 2017 · 2 comments

Comments

@slaFFik
Copy link

slaFFik commented Nov 8, 2017

I have enabled notifications in Chrome for the domain where Pimp is installed, but PimpMyLog still shows a read message.

image

@slaFFik
Copy link
Author

slaFFik commented Nov 8, 2017

Obviously, notifications are not working

@stephen-hill
Copy link

I had the same problem. I solved it by switching to HTTPS.

I found this out by calling Notification.requestPermission(); in the Chrome dev console which reported:

[Deprecation] The Notification API may no longer be used from insecure origins. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.

I've not checked the source code, but I suspect this is the reason why notifications don't work over HTTP.

If this is the case, then the error message should be updated to mention HTTPS.

Cheers
Stephen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants