Submitting the form by pressing "enter" on a Number editor doesn't work #537
Comments
glenpike
pushed a commit
to glenpike/backbone-forms
that referenced
this issue
Dec 30, 2016
Remove the onKeyPress handler from the number field as HTML5 number doesn't allow non-numeric input. Add "TODO" test - it won't render field with a non-numeric value. Update example with number field. Fix bug with Form#handleEditorEvents tests running standalone - async in qunit.
glenpike
pushed a commit
to glenpike/backbone-forms
that referenced
this issue
Dec 30, 2016
Remove the onKeyPress handler from the number field as HTML5 number doesn't allow non-numeric input. Add "TODO" test - it won't render field with a non-numeric value. Update example with number field. Fix bug with Form#handleEditorEvents tests running standalone - async in qunit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The implementation of
editors.Number.onKeyPressis faulty and prevents the form from being submitted by pressing the "enter" key.Currently, the newline character
\rgets appended tonewValin https://github.com/powmedia/backbone-forms/blob/master/src/editors/number.js#L50, which makes thenumerictest fail a few lines below, which in turn results in theevent.preventDefault();call.https://jsfiddle.net/s1h0s5mm/1/
The text was updated successfully, but these errors were encountered: