Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design of CaseService #29

Open
jonenst opened this issue Apr 28, 2020 · 0 comments
Open

Improve design of CaseService #29

jonenst opened this issue Apr 28, 2020 · 0 comments

Comments

@jonenst
Copy link
Collaborator

jonenst commented Apr 28, 2020

  • Do you want to request a feature or report a bug?
    Bug

  • What is the current behavior?
    Case service has a weird design. It has a setFileSystem method that is used only for tests. It takes somes dependencies from spring, other not from spring. It checks the filesystem at every request but this should be done only once when the bean is initialized. (right now it can't be done in @PostConstruct by spring because tests initialize the filesystem after that)

  • What is the expected behavior?
    Simpler design, proper initialization

  • What is the motivation / use case for changing the behavior?
    Maintainability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant