Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverloadManagementSystem extensions can't be deserialized when using the default impl. #3166

Open
bc-rte opened this issue Oct 2, 2024 · 1 comment · May be fixed by #3211
Open

OverloadManagementSystem extensions can't be deserialized when using the default impl. #3166

bc-rte opened this issue Oct 2, 2024 · 1 comment · May be fixed by #3211

Comments

@bc-rte
Copy link
Contributor

bc-rte commented Oct 2, 2024

Describe the current behavior

When trying to deserialize an IIDM file with an extension on OverloadManagementSystem, the OverloadManagementSystemSerDe implementation prevents the extension from being deserialized.

This is caused by OverloadManagementSystems' creation in the Network being delayed after the extension creation step.

Describe the expected behavior

the iidm implementation should let extensions on OverloadManagementSystem be deserialized.

Describe the steps

No response

Environment

No response

Relevant Log Output

No response

Extra Information

This is caused by OverloadManagementSystemSerDe's postponeElementCreation handling mechanism using toApply to create OverloadManagementSystem. toApply's implementation occurs at the end of the deserialization process, after extensions.

Ideally, this mechanism should only postpone validation of the element.

@bc-rte
Copy link
Contributor Author

bc-rte commented Oct 7, 2024

fix PR: #3171

@olperr1 olperr1 linked a pull request Feb 14, 2025 that will close this issue
7 tasks
@olperr1 olperr1 moved this from TODO to Waiting for review in Release 03/2025 Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for review
Development

Successfully merging a pull request may close this issue.

2 participants