Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase tap changer presence not taken into account in SLD for 3WT #672

Open
So-Fras opened this issue Feb 21, 2025 · 0 comments · May be fixed by #677
Open

Phase tap changer presence not taken into account in SLD for 3WT #672

So-Fras opened this issue Feb 21, 2025 · 0 comments · May be fixed by #677
Assignees
Labels
bug Something isn't working SLD

Comments

@So-Fras
Copy link
Member

So-Fras commented Feb 21, 2025

Describe the current behavior

The presence of a phase tap changer is taken into account when creating the middle 2wt note (NodeFactory > createMiddle2WTNode).
The componentType of the node is different if the two-winding transformer has a phase tap changer or not (PHASE_SHIFT_TRANSFORMER vs TWO_WINDINGS_TRANSFORMER)

We can find both components in the components.json resource file.

According to the componentType, a different component will be incorporated in the svg, thus allowing to take into account the presence or not of a phase tap changer for 2wt.

With no phase tap changer (no arrow):

Image

With a phase tap changer (symbolized by an arrow):

Image

For three-winding transformers, there is no check to take into account the potential presence of a phase tap changer.

Image

Describe the expected behavior

The presence of phase tap changer should be represented in the SLD for 3wt too.

The difference here is that here, each leg of a 3wt transformer could have a phase tap changer so the arrow should not be drawn in the middle of the 3wt as it is done for 2wt but on the corresponding winding (with the same color as the winding, to enhance readability).

Describe the steps

No response

Environment

powsybl-diagram 4.7.0

Relevant Log Output

No response

Extra Information

The same goes for NAD diagrams:

  • SvgWriter > draw2wt that calls drawPstArrow when the edge is detected as a PST_EDGE
  • Nothing of the kind is done for 3-winding transformers.
@So-Fras So-Fras added bug Something isn't working SLD labels Feb 21, 2025
@quinarygio quinarygio self-assigned this Feb 28, 2025
@quinarygio quinarygio linked a pull request Mar 5, 2025 that will close this issue
8 tasks
@quinarygio quinarygio linked a pull request Mar 5, 2025 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SLD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants