Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the GLUED, STRETCHABLE mentions in the NAD code #673

Open
So-Fras opened this issue Feb 21, 2025 · 0 comments · May be fixed by #676
Open

Remove the GLUED, STRETCHABLE mentions in the NAD code #673

So-Fras opened this issue Feb 21, 2025 · 0 comments · May be fixed by #676
Assignees

Comments

@So-Fras
Copy link
Member

So-Fras commented Feb 21, 2025

Describe the current behavior

Some parts of the NAD code were introduced to deal with node moving (#457) but the feature does not use the introduced code in the end.

Describe the expected behavior

We could lighten the code by removing (for example) the GLUED_CLASS, the STRETCHABLE_CLASS and the GLUED_CENTER_CLASS.
Everything that was introduced in the #457 PR and that is not used should be removed.

Describe the steps

No response

Environment

powsybl-diagram 4.7.0

Relevant Log Output

No response

Extra Information

Some attention should be paid on whether the introduced code is not used in the powsybl-network-viewer repository anyway.

@So-Fras So-Fras added bug Something isn't working Refactoring NAD and removed bug Something isn't working labels Feb 21, 2025
@quinarygio quinarygio self-assigned this Feb 27, 2025
@quinarygio quinarygio linked a pull request Feb 28, 2025 that will close this issue
9 tasks
@quinarygio quinarygio linked a pull request Feb 28, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants