Throw a comprehensive exception when a terminal ref of a busbar section on is written in bus-breaker or bus-branch (#295) #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbagu
requested changes
May 31, 2021
| // make sure no error is thrown while exporting to NODE_BREAKER topology | ||
| std::stringstream ss; | ||
| Network::writeXml("network.xiidm", ss, network, converter::ExportOptions(properties)); | ||
| Network::readXml("network.xiidm", ss); |
There was a problem hiding this comment.
You should properly assert that Network::readXml and Network::writeXml don't throw any exception using BOOST_CHECK_NO_THROW. It seems to be possible to write something like that:
BOOST_CHECK_NO_THROW({
std::stringstream ss;
Network::writeXml("network.xiidm", ss, network, converter::ExportOptions(properties));
Network::readXml("network.xiidm", ss);
});
| @@ -57,6 +59,11 @@ void TerminalRefXml::writeTerminalRef(const Terminal& terminal, NetworkXmlWriter | |||
| if (!context.getFilter().test(c)) { | |||
| throw PowsyblException(stdcxx::format("Oups, terminal ref point to a filtered equipment %1%", c.get().getId())); | |||
| } | |||
| if (terminal.getVoltageLevel().getTopologyKind() == TopologyKind::NODE_BREAKER | |||
| && context.getOptions().getTopologyLevel() != TopologyLevel::NODE_BREAKER | |||
| && stdcxx::isInstanceOf<BusbarSection>(terminal.getConnectable())) { | |||
There was a problem hiding this comment.
I would put the && operators at the end of the line instead of the beginning of the lines
…on is written in bus-breaker or bus-branch (#295) Signed-off-by: Sébastien LAIGRE <[email protected]>
Signed-off-by: Mathieu BAGUE <[email protected]>
mathbagu
force-pushed
the
issue295-comprehensiveErrorMessage
branch
from
2f6a756 to
725d8fc
Compare
|
Kudos, SonarCloud Quality Gate passed! |
mathbagu
pushed a commit
that referenced
this pull request
Nov 30, 2021
…on on is written in bus-breaker or bus-branch (#295) (#323) Signed-off-by: Sébastien LAIGRE <[email protected]> Signed-off-by: Mathieu BAGUE <[email protected]>
mathbagu
pushed a commit
that referenced
this pull request
Jan 10, 2022
…on on is written in bus-breaker or bus-branch (#295) (#323) Signed-off-by: Sébastien LAIGRE <[email protected]> Signed-off-by: Mathieu BAGUE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sébastien LAIGRE [email protected]
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#295
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)