feat: let consumeRun throw to let message broker handle failures #91
+70
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joris Mancini <[email protected]>
TheMaskedTurtle
force-pushed
the
feat/rabbit-error-handling
branch
from
ed6c931 to
dfa0f28
Compare
Signed-off-by: Joris Mancini <[email protected]>
jonenst
reviewed
Dec 16, 2024
| * @author Joris Mancini <joris.mancini_externe at rte-france.com> | ||
| */ | ||
| public class ComputationException extends RuntimeException { | ||
| public ComputationException(String message, Throwable cause) { |
There was a problem hiding this comment.
probably better to add the constructor without cause right now
jonenst
reviewed
Dec 16, 2024
| isCanceled = future.cancel(true); // cancel computation in progress | ||
| if (isCanceled) { | ||
| if (future == null) { | ||
| cleanResultsAndPublishCancel(cancelContext.resultUuid(), cancelContext.receiver()); |
There was a problem hiding this comment.
this will be run on all but one server who is doing the computation ?
There was a problem hiding this comment.
it looks like it's already the case after this method returns...?
There was a problem hiding this comment.
before we did publishCancelFail but now we do cleanResults and publishStop
jonenst
reviewed
Dec 16, 2024
| cleanResultsAndPublishCancel(cancelContext.resultUuid(), cancelContext.receiver()); | ||
| } else { | ||
| boolean isCanceled = future.cancel(true); // cancel computation in progress | ||
| if (future.isDone() || isCanceled) { |
There was a problem hiding this comment.
Not sure about adding this clean when the computation is done
Signed-off-by: Joris Mancini <[email protected]>
jonenst
reviewed
Dec 17, 2024
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| } catch (CancellationException e) { | ||
| LOGGER.info("Computation was interrupted"); |
There was a problem hiding this comment.
Better to add context (resultUuid) to this log just like above it ?
Signed-off-by: Joris Mancini <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Change behavior of computation consumer to let it throw so that message broker can handle failures
Does this PR introduce a breaking change or deprecate an API?