Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SysTypes According to Zones #16

Open
arshadd-b opened this issue Nov 26, 2024 · 2 comments
Open

Add SysTypes According to Zones #16

arshadd-b opened this issue Nov 26, 2024 · 2 comments
Assignees

Comments

@arshadd-b
Copy link
Contributor

SysTypes are different across Zones.
Refer here #15

@arshadd-b
Copy link
Contributor Author

/assign

@arshadd-b
Copy link
Contributor Author

arshadd-b commented Dec 4, 2024

Hi @dharaneeshvrd @Karthik-K-N
To handle SysTypes according to zone i am thinking to keep map of Zones where key will be zone and value will be list of SysTypes

Sample structure

"dal": {
		Description: "Dallas, USA",
		VPCRegion:   "us-south",
		COSRegion:   "us-south",
		Zones: map[string]Zone{
			"dal10": {SysTypes: []string{"s922", "e980"}},
			"dal12": {SysTypes: []string{"s922", "e980", "s1022"}},
		},
		VPCZones: []string{"us-south-1", "us-south-2", "us-south-3"},
	},

We have to change the logic in these below functions

ValidateZone
ZoneNames
RegionFromZone
AvailableSysTypes

there are no parameters changes in these function except AvailableSysTypes
In AvailableSysTypes currently we just take region as a parameter now with new change we have to add zone as well
So to get sysTypes we need both region and zone

Also I have checked where these functions are getting used
Since in only one function AvailableSysTypes where we are changing the signature and this function till now is not getting called anywhere

So I don't see major impact
Please let me know your thoughts
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant