Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate deprecation/disablement warnings under Upload release asset workflow. #712

Open
kishen-v opened this issue Dec 4, 2024 · 3 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@kishen-v
Copy link
Contributor

kishen-v commented Dec 4, 2024

What happened:

  1. There are few warnings reported under Upload release asset workflow, which are related to the usage of actions which are not maintained/publicly archived. The objective is to use suitable alternatives which are listed under the same archived actions/* repositories.
  2. Usage of set-output command has been deprecated and is bound for disablement.
    Ref: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  3. Usage of GH internal constructs : Build matrices to build for a combination of GOOS/GOARCH. Ref

Reference: https://github.com/ppc64le-cloud/pvsadm/actions/runs/11892741850

What you expected to happen:
No warnings under workflows.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • pvsadm version (use pvsadm --version):
  • Environment - On-Prem or IBM PowerVS:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Others:
@kishen-v kishen-v added the kind/bug Categorizes issue or PR as related to a bug. label Dec 4, 2024
@kishen-v
Copy link
Contributor Author

kishen-v commented Dec 4, 2024

/remove-kind bug
/good-first-issue

@ppc64le-cloud-bot
Copy link
Contributor

@kishen-v:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-kind bug
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed kind/bug Categorizes issue or PR as related to a bug. labels Dec 4, 2024
@carmal891
Copy link
Contributor

/assign

@kishen-v kishen-v added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

3 participants