From 1b87ba80e9428698955010daa2e4133bf11d4629 Mon Sep 17 00:00:00 2001 From: Peter Postma Date: Mon, 5 Jun 2023 20:59:13 +0200 Subject: [PATCH] RSpec: disable monkey patching & enable warnings. --- .../active_record_extension_spec.rb | 2 +- spec/smart_paginate/paginate_spec.rb | 2 +- spec/smart_paginate/paginating_array_spec.rb | 2 +- spec/spec_helper.rb | 28 ++++++++----------- 4 files changed, 15 insertions(+), 19 deletions(-) diff --git a/spec/smart_paginate/active_record_extension_spec.rb b/spec/smart_paginate/active_record_extension_spec.rb index 780b786..0f4f6ab 100644 --- a/spec/smart_paginate/active_record_extension_spec.rb +++ b/spec/smart_paginate/active_record_extension_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SmartPaginate::ActiveRecordExtension do +RSpec.describe SmartPaginate::ActiveRecordExtension do before(:all) do ActiveRecord::Base.connection_pool.with_connection do |conn| conn.create_table :users do |t| diff --git a/spec/smart_paginate/paginate_spec.rb b/spec/smart_paginate/paginate_spec.rb index 1ff3115..e28db84 100644 --- a/spec/smart_paginate/paginate_spec.rb +++ b/spec/smart_paginate/paginate_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SmartPaginate::Paginate do +RSpec.describe SmartPaginate::Paginate do describe '#current_page' do it 'accepts nil as current_page and converts it to 1' do page = described_class.new(nil, 10) diff --git a/spec/smart_paginate/paginating_array_spec.rb b/spec/smart_paginate/paginating_array_spec.rb index 9f84940..2fa29b0 100644 --- a/spec/smart_paginate/paginating_array_spec.rb +++ b/spec/smart_paginate/paginating_array_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe SmartPaginate::PaginatingArray do +RSpec.describe SmartPaginate::PaginatingArray do subject(:array) { described_class.new(%w[1 2 3 4 5 6 7 8 9 10]) } describe '#paginate' do diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 6233de8..2b812d2 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -49,20 +49,17 @@ mocks.verify_partial_doubles = true end -# The settings below are suggested to provide a good initial experience -# with RSpec, but feel free to customize to your heart's content. -=begin # These two settings work together to allow you to limit a spec run # to individual examples or groups you care about by tagging them with # `:focus` metadata. When nothing is tagged with `:focus`, all examples # get run. - config.filter_run :focus - config.run_all_when_everything_filtered = true + # config.filter_run :focus + # config.run_all_when_everything_filtered = true # Allows RSpec to persist some state between runs in order to support # the `--only-failures` and `--next-failure` CLI options. We recommend # you configure your source control system to ignore this file. - config.example_status_persistence_file_path = "spec/examples.txt" + # config.example_status_persistence_file_path = "spec/examples.txt" # Limits the available syntax to the non-monkey patched syntax that is # recommended. For more details, see: @@ -78,28 +75,27 @@ # Many RSpec users commonly either run the entire suite or an individual # file, and it's useful to allow more verbose output when running an # individual spec file. - if config.files_to_run.one? - # Use the documentation formatter for detailed output, - # unless a formatter has already been configured - # (e.g. via a command-line flag). - config.default_formatter = 'doc' - end + # if config.files_to_run.one? + # # Use the documentation formatter for detailed output, + # # unless a formatter has already been configured + # # (e.g. via a command-line flag). + # config.default_formatter = 'doc' + # end # Print the 10 slowest examples and example groups at the # end of the spec run, to help surface which specs are running # particularly slow. - config.profile_examples = 10 + # config.profile_examples = 10 # Run specs in random order to surface order dependencies. If you find an # order dependency and want to debug it, you can fix the order by providing # the seed, which is printed after each run. # --seed 1234 - config.order = :random + # config.order = :random # Seed global randomization in this process using the `--seed` CLI option. # Setting this allows you to use `--seed` to deterministically reproduce # test failures related to randomization by passing the same `--seed` value # as the one that triggered the failure. - Kernel.srand config.seed -=end + # Kernel.srand config.seed end