Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a new background/audio file in the editor may remove file which is used in other difficulties #30806

Open
peppy opened this issue Nov 21, 2024 Discussed in #30435 · 0 comments · May be fixed by #30860
Open

Adding a new background/audio file in the editor may remove file which is used in other difficulties #30806

peppy opened this issue Nov 21, 2024 Discussed in #30435 · 0 comments · May be fixed by #30860
Assignees
@frenzibyte
Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@peppy
Copy link
Member

peppy commented Nov 21, 2024

The method for replacing the background doesn't currently check if the old background was used or not:

osu/osu.Game/Screens/Edit/Setup/ResourcesSection.cs

Lines 84 to 94 in 7cd724f

// remove the previous background for now.
// in the future we probably want to check if this is being used elsewhere (other difficulties?)
var oldFile = set.GetFile(working.Value.Metadata.BackgroundFile);
using (var stream = source.OpenRead())
{
if (oldFile != null)
beatmaps.DeleteFile(set, oldFile);
beatmaps.AddFile(set, stream, destination.Name);
}

Same applies to audio file.

Discussed in #30435

Originally posted by AFasterSlowpoke October 27, 2024
When I drag an image to the osu lazer editor to set the background, it changes the background for all difficulties, instead of just the difficulty i'm currently editing.

I think that it would improve the osu lazer editor if dragging and dropping a new background only changed the current difficulty's background, with a button to set the current difficulty's background to all other difficulties.
@peppy peppy added area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users. labels Nov 21, 2024
@bdach bdach moved this from Needs discussion to Needs implementation in osu! client development focus Nov 22, 2024
@frenzibyte frenzibyte self-assigned this Nov 24, 2024
@frenzibyte frenzibyte linked a pull request Nov 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frenzibyte frenzibyte

Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
osu! client development focus
Status: Needs implementation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow choosing different background/audio files for individual difficulties frenzibyte/osu
2 participants
@peppy @frenzibyte