Remove all default exports (major) #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixing both default and named exports has no clearly defined behaviour and can easily lead to unexpected results. Some tools use a combination of "default" + "__esModule" property and others ignore named exports completely if both are found. Those issues are difficult to debug when multiple tools are used together. This change makes some code redundant by not having to patch a hand crafted exports object for commonjs environments.
marvinhagemeister
force-pushed
the
remove-default-export
branch
from
ac04e79
to
45c2938
Compare
JoviDeCroock
approved these changes
Mar 10, 2021
|
Couldn't we provide only a default export? None of the other exported methods were widely used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixing both default and named exports has no clearly defined behaviour and can easily lead to unexpected results. Some tools use a combination of
default+__esModuleproperty and others ignore named exports completely if both are found. Those issues are difficult to debug when multiple tools are used together.This change makes some code redundant by not having to patch a hand crafted exports object for commonjs environments.