Add support for mixed rendering #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixed rendering is a mode that works like shallow rendering, but where you can specify a list of components you want to render even tho they are deeply nested.
developit
reviewed
Oct 12, 2017
src/index.js
Outdated
| nodeName = getComponentName(nodeName); | ||
| if (opts.shallow && | ||
| (inner || opts.renderRootComponent===false) && | ||
| !opts.alwaysRenderedComponents.includes(componentName)) { |
There was a problem hiding this comment.
Needs to use indexOf()!==-1 because this lib supports IE9+.
src/index.js
Outdated
| * @param {Array} alwaysRenderedComponents List of components that should be rendered with shallow rendering | ||
| * @param {Object} [context={}] Optionally pass an initial context object through the render path. | ||
| */ | ||
| let mixedRender = (vnode, alwaysRenderedComponents = [], context) => { |
There was a problem hiding this comment.
This file is size-constrained - would it be alright to add the alwaysRenderedComponents option, but not export another method (mixedRender)? That would keep things reasonably minimal.
|
@developit I've updated the PR, but kept the unit tests in a separate file. Do you want me to move them as well? |
|
Hi @Saegrov! Sorry for the delay - happy to have the unit tests in their own file. I think this should be good to merge, just need to check the file size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixed rendering is a mode that works like shallow rendering, but where
you can specify a list of components you want to render even tho they
are deeply nested.
We have a use case where we are using shallow rendering and Cheerio for unit testing our Preact components. We are using a redux-connect like higher order component to connect some components to our global state.
When testing a component, that uses another component that is wrapped in a HOC, the shallow renderer stops at the HOC.
With mixed rendering we can white list components we want to render and test that the wrapped components are used correctly.